Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fix flaky testEqualsAndHashcode in SearchRequestTests #10869

Merged
merged 1 commit into from
Nov 2, 2023
Merged

[Backport 2.x] Fix flaky testEqualsAndHashcode in SearchRequestTests #10869

merged 1 commit into from
Nov 2, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d46a012 from #10649.

@github-actions
Fix flaky testEqualsAndHashcode in SearchRequestTests (#10649)
67e7602 
Signed-off-by: David Zane <[email protected]>
(cherry picked from commit d46a012)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 67e7602

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@dzane17
Copy link
Contributor

dzane17 commented Oct 23, 2023

@reta please merge backport

@reta
Copy link
Collaborator

reta commented Oct 23, 2023

#10798

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

peternied
peternied approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@peternied peternied left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll see about getting this merged

@peternied peternied self-assigned this Nov 2, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Gradle Check (Jenkins) Run Completed with:

@peternied peternied mentioned this pull request Nov 2, 2023
Closed
@peternied
Copy link
Member

Is the failure a flaky test unrelated to your change?

#10758

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.index.shard.RemoteIndexShardTests.classMethod
      1 org.opensearch.index.shard.RemoteIndexShardTests.testSegRepSucceedsOnPreviousCopiedFiles
      1 org.opensearch.cluster.allocation.AwarenessAllocationIT.testThreeZoneOneReplicaWithForceZoneValueAndLoadAwareness

@codecov Codecov
Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #10869 (67e7602) into 2.x (71d89ca) will decrease coverage by 0.08%.
Report is 43 commits behind head on 2.x.
The diff coverage is 70.63%.

@@             Coverage Diff              @@
##                2.x   #10869      +/-   ##
============================================
- Coverage     70.93%   70.85%   -0.08%     
+ Complexity    58736    58690      -46     
============================================
  Files          4844     4844              
  Lines        277352   277465     +113     
  Branches      40683    40704      +21     
============================================
- Hits         196736   196597     -139     
- Misses        63886    64163     +277     
+ Partials      16730    16705      -25
Files Coverage Δ
...earch/action/search/AbstractSearchAsyncAction.java 80.00% <100.00%> (+0.39%) ⬆️
...g/opensearch/action/search/MultiSearchRequest.java 80.34% <100.00%> (+0.46%) ⬆️
...opensearch/action/search/SearchResponseMerger.java 78.81% <100.00%> (+0.10%) ⬆️
...rg/opensearch/common/settings/ClusterSettings.java 92.85% <ø> (ø)
...pensearch/common/settings/IndexScopedSettings.java 100.00% <ø> (ø)
...rg/opensearch/index/translog/RemoteFsTranslog.java 75.60% <100.00%> (+0.48%) ⬆️
...va/org/opensearch/action/search/SearchRequest.java 82.42% <81.81%> (+0.71%) ⬆️
...arch/gateway/remote/RemoteClusterStateService.java 70.43% <87.50%> (+0.45%) ⬆️
.../main/java/org/opensearch/index/IndexSettings.java 86.82% <66.66%> (-0.27%) ⬇️
...pensearch/rest/action/search/RestSearchAction.java 37.34% <0.00%> (-0.48%) ⬇️
... and 2 more

... and 462 files with indirect coverage changes

@peternied peternied merged commit b4293dd into 2.x Nov 2, 2023
41 of 67 checks passed
@github-actions github-actions bot deleted the backport/backport-10649-to-2.x branch November 2, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternied peternied peternied approved these changes

@kkmr kkmr kkmr approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees

@peternied peternied

Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dzane17 @reta @peternied @kkmr